We should also consider including the playback position history in the SettingsExpander items.

We should also consider including the playback position history in the SettingsExpander items.

Disagree. If we want to show all the entries in the playback position history it should be outside of the SettingsExpander. Perhaps a popup. Anyway it's out of scope for this PR.

@United600 I made LastPositionTracker a singleton, so now SettingsPageViewModel can properly delete the saved progression.

@United600 I made LastPositionTracker a singleton, so now SettingsPageViewModel can properly delete the saved progression.

Can confirm the cache is now being disposed of correctly.
I'll do a minor refactor based on #772, I like some of its choices.

May be unrelated, but what do you think of using the "progression" or "media progression" term instead of the "last position" term?

May be unrelated, but what do you think of using the "progression" or "media progression" term instead of the "last position" term?

Probably better.
Also the description can definitely be improved. It was inspired by some system setting but the first person feels weird.

I also wonder, should it be limited to video files? And is this last position "format" conducive to be added as a progress bar to the ‘CommonGridViewItem’?

Should I merge the resume and remember playback position cards? If so, which one do you prefer? No InfoBar is also an option.

If the "Always resume" option is under the "Playback position" expander, then I don't think we need to explain why the option is disabled. I thought the "Always resume" option would remain in the General section. This ordering works as well, and we don't need to deal with extra explanation.

May be unrelated, but what do you think of using the "progression" or "media progression" term instead of the "last position" term?

Probably better. Also the description can definitely be improved. It was inspired by some system setting but the first person feels weird.

Let's implement this in a separate PR.

I also wonder, should it be limited to video files? And is this last position "format" conducive to be added as a progress bar to the ‘CommonGridViewItem’?

In most cases, I agree that this feature only makes sense with video files. But I think we should artificially limit this feature because it works in most cases. Perhaps we can make the "Always resume" option only affect video files. That option may break the music listening experience if turned on.

If the "Always resume" option is under the "Playback position" expander, then I don't think we need to explain why the option is disabled. I thought the "Always resume" option would remain in the General section. This ordering works as well, and we don't need to deal with extra explanation.

Did some copywriting on both settings, what do you think?

I also wonder, should it be limited to video files? And is this last position "format" conducive to be added as a progress bar to the ‘CommonGridViewItem’?

In most cases, I agree that this feature only makes sense with video files. But I think we should artificially limit this feature because it works in most cases. Perhaps we can make the "Always resume" option only affect video files. That option may break the music listening experience if turned on.

Yeah, it does makes sense for audiobooks (and podcasts). Though our support for them isn't exactly stellar.

If the "Always resume" option is under the "Playback position" expander, then I don't think we need to explain why the option is disabled. I thought the "Always resume" option would remain in the General section. This ordering works as well, and we don't need to deal with extra explanation.

Did some copywriting on both settings, what do you think?

Just nitpicking: the description for "Playback position" is a bit wordy, and the first-person usage is... odd. Otherwise, it's good. I don't mind shipping it as-is.

Just nitpicking: the description for "Playback position" is a bit wordy, and the first-person usage is... odd. Otherwise, it's good.

It was inspired by the search settings.

I don't mind shipping it as-is.

I think the resume setting should be moved to the playback position expander items.

The 1424cdd commit moves and updates the "Always resume" setting. If the change doesn't feel right to you, I'll go ahead and revert it (or some parts).